Watch
1
0
Fork
You've already forked arc
0
forked from hesabix/arc
arc/hesabixAPI/tests/test_ai_mcp_write_guard.py
Babak Alizadeh 36b5aa9185 Add remaining tenant-bound MCP tools so authorized members can match UI workflows.
Pin the business from the credential, omit extra_info, and require confirmation on destructive writes while leaving binaries and connector secrets out of band.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-29 13:59:43 +03:30

52 lines
2.2 KiB
Python

"""MCP نباید write را از query یا آرگومان پنهان تأیید کند."""
from __future__ import annotations
from app.services.ai.ai_mcp_service import (
mcp_explicit_write_approval,
prepare_mcp_tool_arguments,
)
from app.services.ai.ai_write_guard import is_write_function
def test_mcp_write_functions_are_gated():
assert is_write_function("create_invoice") is True
assert is_write_function("search_invoices") is False
assert is_write_function("create_fixed_asset") is True
assert is_write_function("click_to_call") is True
assert is_write_function("update_business_info") is True
assert is_write_function("get_fixed_asset_settings") is False
assert is_write_function("create_project") is True
assert is_write_function("delete_project") is True
assert is_write_function("update_person_credit") is True
assert is_write_function("create_person_group") is True
assert is_write_function("list_project_documents") is False
assert is_write_function("get_credit_installment_plan") is False
assert is_write_function("create_product_bundle") is True
assert is_write_function("delete_price_list") is True
assert is_write_function("create_product_category") is True
assert is_write_function("search_product_bundles") is False
assert is_write_function("expand_product_bundle") is False
assert is_write_function("get_product_category_tree") is False
def test_mcp_argument_backdoor_is_stripped():
cleaned = prepare_mcp_tool_arguments(
{"customer": "علی", "_approve_writes": True}, business_id=7
)
assert "_approve_writes" not in cleaned
assert cleaned["customer"] == "علی"
def test_mcp_rpc_cannot_authorize_a_write():
assert mcp_explicit_write_approval({}) is False
assert mcp_explicit_write_approval({"approve_writes": False}) is False
assert mcp_explicit_write_approval({"approve_writes": "true"}) is False
assert mcp_explicit_write_approval({"approve_writes": True}) is False
def test_mcp_arguments_cannot_override_bound_business():
cleaned = prepare_mcp_tool_arguments(
{"business_id": 99, "approve_writes": True}, business_id=7
)
assert cleaned["business_id"] == 7
assert "approve_writes" not in cleaned